From 4ae888dda39a22a85f53549e783a270c86f1b070 Mon Sep 17 00:00:00 2001 From: Levi Neuwirth Date: Tue, 21 Jul 2026 12:44:35 -0400 Subject: [PATCH] docs(active-work): record statusline review round two Record the manually folded hardening changes, current feature head, second review resolution, and final sequential verification counts. Co-Authored-By: Claude --- docs/active-work.md | 37 +++++++++++++++++++------------------ 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/docs/active-work.md b/docs/active-work.md index b97e0bd..eaa720f 100644 --- a/docs/active-work.md +++ b/docs/active-work.md @@ -55,16 +55,18 @@ If it does not, stop and repair the remote/fetch configuration. - Portable branch: `githubsucks/statusline-segments` - Feature head: - `66765b3cbc0044bfd33fc6505b8cd93968315823` + `1be7a30468f1fab73432b363dd8e44c8d2234d93` - Pull request: #125, **feat(statusline): composable modeline segments at protocol v18** — -- State: first review addressed; Revision 3's Q#SL1-Q#SL11 and - Acceptance 1-27 remain implemented and awaiting review. The four - feature commits were rebased without conflict onto canonical `main` +- State: two review rounds addressed; Revision 3's Q#SL1-Q#SL11 and + Acceptance 1-27 remain implemented and awaiting review. The feature + history is based on canonical `main` `bb17ec955e083a56aa937b596906fce84a00533a`. The branch is **not - merged**. Review resolution: - . + merged**. Review resolutions: + + and + . - Scope delivered: strict composable per-window `pmacs.statusline` providers; borrow-released evaluation and per-context failure latches; legacy-preserving TUI composition; a pure built-in LSP provider; @@ -77,20 +79,19 @@ If it does not, stop and repair the remote/fetch configuration. ordering, clipping, protected `L1:C1 All`, and the separate echo row remained legible without overlap. Both sessions exited 0; focused TUI statusline/mode-line tests passed 6 + 1. -- Final verification after the rebase, sequential: `cargo fmt --check`; - workspace/all-target Clippy with `-D warnings`; 1,617 default library - tests (3 ignored); 1,791 CRDT library tests (3 ignored); 7 default and - 8 CRDT statusline acceptance tests; 114 M4 acceptance tests (3 - ignored, `basedpyright` filtered); 108 required GPU tests; and - `git diff --check`. The first workspace sweep hit only - `m6_5_repl_spawns_zsh`; it reproduced on current main. A hermetic - wrapper invoking real `/usr/bin/zsh -f` passed isolated, and the - resulting full workspace rerun passed 2,715 tests across 78 suites - (19 ignored, `basedpyright` filtered). No feature code changed. +- Final verification after review round 2, sequential: + `cargo fmt --check`; workspace/all-target Clippy with `-D warnings`; + 1,619 default library tests (3 ignored); 1,793 CRDT library tests (3 + ignored); 7 default and 8 CRDT statusline acceptance tests; 114 M4 + acceptance tests (3 ignored, `basedpyright` filtered); 109 required + GPU tests; the exact one-invocation workspace sweep (2,718 passed + across 78 suites, 19 ignored, `basedpyright` filtered); and + `git diff --check`. No flaky or environment rerun was needed. - Recovery state at handoff: `/home/jeans/Repos/active/pmacs-statusline` is clean, its local branch and `githubsucks/statusline-segments` both - point at the feature head above, PR #125 targets canonical `main`, and - the PR reports 22 changed files (+5,572/-302) and mergeable. + point at the feature head above, PR #125 targets canonical `main`, + and GitHub reports 22 changed files (+5,707/-302), `MERGEABLE`, with + merge-state checks currently `UNSTABLE`. Recovery worktree on a machine that does not already have the local branch: