Pass-12 batch: mark the resolved I-series rows done
A status sweep: the I-series Pass-12 candidates are all closed, but the tracker
and two crate DECISIONS.md files still described them as open.
- PASS12_BATCH.md: P12-I1 (structural-placeholder pipeline) is resolved by I-1
-- to_constrained now builds real notation and the Engraver re-spaces it;
P12-I3 (BRAVURA_METRICS approximations) is resolved by I-4a -- metrics
re-extracted from the same pinned 1.392 font, containment-tested. Both rows
struck through and marked done.
- render-svg/DECISIONS.md: fixed the stale P12-I2 bullet, which still said the
MUSCLOID derivation was unwired and the determinism crate exposed no tag (a
miss from the P12-I2 commit); now marked resolved.
- engrave/DECISIONS.md: its P12 section described P12-I1/I3 as open and omitted
I2; rewritten so all three read resolved.
The batch's top-level Status stays OPEN -- the H-series and K-series candidates
remain. Docs-only; no code change.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
parent
e2d389330d
commit
3ef1a8abd9
|
|
@ -71,16 +71,17 @@ Catalog lands (Phase 3, explicitly out of Agent I's scope).
|
|||
|
||||
## Pass 12 candidates
|
||||
|
||||
See `spec/PASS12_BATCH.md` (rows P12-I1, P12-I2, P12-I3). In brief:
|
||||
See `spec/PASS12_BATCH.md` (rows P12-I1, P12-I2, P12-I3) — all three are now
|
||||
resolved:
|
||||
|
||||
- **P12-I1** — the v0 `to_logical`/`to_constrained` pipeline is a *structural
|
||||
placeholder* (each layout object → one arbitrary glyph by `discriminant % N`,
|
||||
laid out at `y = 0`), not real notation. Chapter 7 says the *logical* stage has
|
||||
"engraving decisions made"; the spec should clarify which engraving decisions
|
||||
(glyph-by-duration selection, pitch→staff-position, clef/key/meter/barline
|
||||
realization, stems/beams) are core-IR construction versus solver work, so the
|
||||
real-notation engraving has a defined home before it is built next phase.
|
||||
- **P12-I3** — `layout-ir`'s bundled `BRAVURA_METRICS` are *approximations* and
|
||||
disagree with the genuine Bravura outlines the renderer now bundles (e.g.
|
||||
`timeSig4` vertical registration). Real spacing needs exact metrics; the metrics
|
||||
table should be regenerated from the font or reconciled with the outline source.
|
||||
- **P12-I1 (resolved by I-1)** — the v0 pipeline was a *structural placeholder*
|
||||
(one arbitrary glyph per object at `y = 0`). `to_constrained` now builds real
|
||||
notation (clef-relative noteheads, accidentals, key/time signatures, rests,
|
||||
barlines, stems) and the Engraver re-spaces it; the Ch 7 engraving boundary
|
||||
resolved to notation-construction-in-`to_constrained`, spacing-in-the-Engraver.
|
||||
- **P12-I2 (resolved)** — the `MUSCLOID` layout-object id derivation is wired
|
||||
(`epiphany-determinism` reserves the built-in tag; `layout-ir` provenance and the
|
||||
engraving-decision id route through it).
|
||||
- **P12-I3 (resolved by I-4a)** — `BRAVURA_METRICS` is re-extracted from the same
|
||||
SHA-pinned `bravura-1.392` font the outlines come from, with bboxes rounded
|
||||
outward to contain the drawn ink (a `render-svg` test proves containment).
|
||||
|
|
|
|||
|
|
@ -98,7 +98,8 @@ See `spec/PASS12_BATCH.md` (rows P12-I1, P12-I2, P12-I3). Most relevant here:
|
|||
landed. The real notation pass and real-Engraver goldens now close that gate;
|
||||
the stub path remains locked as an interface/reference mode, not the visual
|
||||
deliverable.
|
||||
- **P12-I2** — stable layout-object id derivation (`MUSCLOID`, Pass-11 item 2.6,
|
||||
deferred to Agent I) is still unwired: the determinism crate exposes no
|
||||
`MUSCLOID` tag and is frozen. The renderer traces provenance by the existing
|
||||
provisional `stable_id`; wiring the ratified derivation is Track A work.
|
||||
- **P12-I2 (resolved)** — the stable layout-object id derivation (`MUSCLOID`,
|
||||
Pass-11 item 2.6) is wired: `epiphany-determinism` reserves the built-in
|
||||
`MUSCLOID` tag and `layout-ir` provenance routes through it. The renderer traces
|
||||
provenance by the (now `MUSCLOID`-tagged) `stable_id`; only the `data-prov` hex in
|
||||
the goldens changed (the ids are non-canonical).
|
||||
|
|
|
|||
|
|
@ -26,9 +26,9 @@ code instead is the failure mode this batch exists to prevent.
|
|||
| P12-H3 | `epiphany-core` H | Chromatic-run convention (ascending = sharps, descending = flats) is only a *tiebreak* in the centre-of-gravity rule, so an isolated chromatic run with no tonal context may pick the enharmonic the convention would not. Voice-leading refinement deferred. | G / Pass 12 (spelling) |
|
||||
| P12-H4 | `epiphany-core` H | Decomposition simplifications: single governing meter per region (multi/mid-region meter changes deferred); region origin assumed a barline (anacrusis deferred); compound-meter beat grouping beyond the dyadic default; tuplet nesting and cross-beat tuplet members; double+ augmentation dots (`MAX_DOTS = 1`). | G (decomposition scope) |
|
||||
| P12-H5 | `epiphany-core` H | Automatic spelling under aleatoric regions (the spec's open question). H spells pitches region-independently but performs no region-specific aleatoric spelling; defer if the algorithm does not generalise cleanly. | G / Pass 12 (open question) |
|
||||
| P12-I1 | `epiphany-layout-ir` / `engrave` / `render-svg` I | The v0 `to_logical`/`to_constrained` pipeline is a **structural placeholder**: each layout object becomes one *arbitrary* glyph (`BRAVURA_METRICS[discriminant % N]`) at `y = 0`, not real notation. Chapter 7 says the *logical* stage has "engraving decisions made"; the spec should clarify which engraving decisions (glyph-by-duration selection, pitch→staff-position, clef/key/meter/barline realization, stems/beams) are core-IR construction versus solver work, so the real-notation engraving has a defined home before it is built next phase. Consequence: the QUICKSTART human visual-acceptance gate ("the SVG visually parses as standard notation") is a **next-phase** gate, *not* met by stub output — this phase's gate is renderer correctness/faithfulness. | G / Pass 12 (Ch 7 engraving boundary) |
|
||||
| ~~P12-I1~~ **RESOLVED (I-1)** | `epiphany-layout-ir` / `engrave` / `render-svg` I | The v0 pipeline was a **structural placeholder** (one *arbitrary* glyph per object at `y = 0`), not real notation. **Resolved by I-1 (Phase 2-3):** `to_constrained` now builds real notation — clef-relative noteheads (by `NoteValue`), spelling-derived accidentals, key/time signatures, rests, barlines, and the staff-line/stem strokes — and the Engraver re-spaces it; the human visual-acceptance gate is met (goldens locked against the stub *and* the real Engraver). The Ch 7 engraving-boundary question resolved to: notation construction lives in `to_constrained`, horizontal spacing in the Engraver. | ✅ done |
|
||||
| ~~P12-I2~~ **RESOLVED (wired)** | `epiphany-determinism` / `epiphany-layout-ir` I | Stable layout-object id derivation (`MUSCLOID`, Pass-11 item 2.6). **Wired:** `epiphany-determinism` now reserves the built-in `DomainTag::LAYOUT_OBJECT_ID` (`MUSCLOID`), and `layout-ir`'s provenance derivations (single / multiply-manifested / synthesized) plus the engraving-decision id route through it (no longer borrowing `MUSCCONF`). Layout ids stay non-canonical, so only `data-prov` hex in the render goldens changed; no durable/interchanged artifact. See `layout-ir/DECISIONS.md` and `req:layoutir:object-id-derivation`. | ✅ done |
|
||||
| P12-I3 | `epiphany-layout-ir` I | The bundled `BRAVURA_METRICS` are *approximations* that disagree with the genuine Bravura outlines the renderer now extracts from the font (e.g. `timeSig4`: metrics bbox `[40,0,1240,2048]` vs real outline ≈ `[0.08,-1.0,1.8,1.004]` staff spaces). Real spacing needs exact metrics; regenerate the metrics table from the font or reconcile it with the outline source. | G / Pass 12 (glyph metrics) |
|
||||
| ~~P12-I3~~ **RESOLVED (I-4a)** | `epiphany-layout-ir` I | The bundled `BRAVURA_METRICS` were *approximations* disagreeing with the renderer's genuine outlines. **Resolved by I-4a:** the metrics table is re-extracted from the **same** SHA-pinned `bravura-1.392` font the outlines come from, with bboxes rounded *outward* so each metric box contains the drawn ink (a `render-svg` test proves containment); `BRAVURA_VERSION = SemVer(1, 392, 0)`. A coupled barline-placement bug it surfaced (bottom-origin glyph floated) was fixed in the same increment. | ✅ done |
|
||||
| P12-K1 | `epiphany-ops` K | A v0 `RespellPitch` carried a `ContentHash` *fingerprint* of the spelling, not the `PitchSpelling`. The v0→v1 migration (Operation Catalog, M1) cannot invert a fingerprint, so it recovers the spelling from the score-graph context (an explicit per-pitch spelling attachment whose canonical bytes hash to the fingerprint) and returns `MigrationError::Irreversible` (bundle opens read-only) when the context lacks it. Every other representative payload migrates self-contained; this is the lone exception. Confirm the read-only fallback is the intended disposition vs. requiring a v0 corpus that preserves spelling pre-images. | G / Pass 12 (migration) |
|
||||
| P12-K2 | `epiphany-ops` K | The `Transpose` op (Operation Catalog, M2 Group 1) carries a minimal `chromatic_steps: i32` interval and `reduce_onto` applies it as a CMN *alteration* shift only. Faithful interval algebra (diatonic vs. chromatic intervals, octave/nominal renormalization, transposition in non-CMN pitch spaces) is the deferred Chapter 4 tuning-catalog territory. The prototype also clamps the shifted alteration to the `i8` range, so an extreme transpose silently saturates instead of renormalizing — another reason the representation needs pinning. Pin the interval representation and transposition semantics when the tuning catalog lands. | G / Pass 12 (tuning) |
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue