neuwirth
/
pmacs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

docs(vterm): record PR 130 review round 2 

Update the durable handoff and active-work ledger with the second-review
fix checkpoint and exact final gate evidence.

Co-authored-by: OpenAI Codex <codex@openai.com>
This commit is contained in:
Levi Neuwirth 2026-07-22 09:10:30 -04:00
parent b9a7e40855
commit 49efa805b5
2 changed files with 24 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
docs/active-work.md
View File

@ -1,6 +1,6 @@
# Active work — cross-machine resume ledger # Active work — cross-machine resume ledger
**Snapshot: 2026-07-21.** This file records volatile work that has not **Snapshot: 2026-07-22.** This file records volatile work that has not
landed on `main`. Read it after `docs/agent-handoff.md`. Remove completed landed on `main`. Read it after `docs/agent-handoff.md`. Remove completed
entries when their PR merges; do not let this become a second permanent entries when their PR merges; do not let this become a second permanent
backlog. backlog.
@ -55,7 +55,7 @@ If it does not, stop and repair the remote/fetch configuration.
## Vterm Stage 2 implementation lane ## Vterm Stage 2 implementation lane
- Portable branch: `githubsucks/vterm-tui` - Portable branch: `githubsucks/vterm-tui`
- Feature head after review round 1: `8702791` - Feature head after review round 2: `b9a7e40`
- Base: canonical `main` @ `f1a2f75` (handoff refresh #128 atop config - Base: canonical `main` @ `f1a2f75` (handoff refresh #128 atop config
registry #127 and Vterm Stage 1 #126). registry #127 and Vterm Stage 1 #126).
- PR: #130, <https://github.com/levineuwirth/pmacs/pull/130>, open against - PR: #130, <https://github.com/levineuwirth/pmacs/pull/130>, open against
@ -70,16 +70,21 @@ If it does not, stop and repair the remote/fetch configuration.
editor bindings; non-terminal context operations error; controller editor bindings; non-terminal context operations error; controller
replacement is atomic per frontend; zero-area layouts retain view anchors; replacement is atomic per frontend; zero-area layouts retain view anchors;
view projection borrows retained rows instead of deep-cloning scrollback. view projection borrows retained rows instead of deep-cloning scrollback.
- Review round 2: addressed. Partial eviction clamps anchors to the first
surviving wrapped-line cell; `invoke_interactive` now inherits only an
authenticated dispatch origin; explicit context failures are named; terminal
mouse routing reads geometry without cloning cells; the framing records the
v18 semantic-controller boundary and bracketed-paste injection deferral.
- Implementation commits: `39e07cb`, `7c39535`, `0a846d9`, `0dacac7`, - Implementation commits: `39e07cb`, `7c39535`, `0a846d9`, `0dacac7`,
`dc92257`, merge `0ddff24`, integration hardening `da8f6ae`, and first-review `dc92257`, merge `0ddff24`, integration hardening `da8f6ae`, first-review
fixes `8702791`. fixes `8702791`, and second-review fixes `b9a7e40`.
- Review-round final verification: `cargo fmt --check`; strict workspace - Second-review final verification: `cargo fmt --check`; strict workspace
Clippy; 1,743 default + 1,919 CRDT library tests (3 ignored each); Clippy; 1,744 default + 1,920 CRDT library tests (3 ignored each);
Stage 1 acceptance 9 default + 10 CRDT; Stage 2 acceptance 4 default + Stage 1 acceptance 9 default + 10 CRDT; Stage 2 acceptance 4 default +
4 CRDT; statusline acceptance 7 default + 8 CRDT; M4 114 passed 4 CRDT; statusline acceptance 7 default + 8 CRDT; M4 114 passed
(3 ignored, 1 filtered); required GPU 109; workspace 2,871 passed across (3 ignored, 1 filtered); required GPU 109; workspace 2,872 passed across
81 suites (19 ignored, 1 filtered); `git diff --check` clean. 81 suites (19 ignored, 1 filtered); `git diff --check` clean.
- Next: second user review. Do not merge without explicit authorization. - Next: user review. Do not merge without explicit authorization.
Recovery worktree on a machine that does not already own the branch: Recovery worktree on a machine that does not already own the branch:

15
docs/agent-handoff.md
View File

@ -1,6 +1,6 @@
# Agent handoff — cross-machine continuity # Agent handoff — cross-machine continuity
**Last updated: 2026-07-22, after Vterm Stage 2 PR #130 review round 1 **Last updated: 2026-07-22, after Vterm Stage 2 PR #130 review round 2
was addressed on `vterm-tui`; config registry (#127), Vterm Stage 1 was addressed on `vterm-tui`; config registry (#127), Vterm Stage 1
terminal core (#126), and handoff refresh (#128) are landed on `main`, terminal core (#126), and handoff refresh (#128) are landed on `main`,
atop completed Themes Arc 4 (#120/#124/#125). Vterm Stage 3 is not atop completed Themes Arc 4 (#120/#124/#125). Vterm Stage 3 is not
@ -261,11 +261,18 @@ commands, read `docs/active-work.md` immediately after this file.
duplicate detach work, and replaced per-view deep scrollback clones with duplicate detach work, and replaced per-view deep scrollback clones with
borrowed live/published row projections. Focused child-input coverage pins borrowed live/published row projections. Focused child-input coverage pins
both unescaped bound-key passthrough and `C-c C-c`. both unescaped bound-key passthrough and `C-c C-c`.
- Review-round final gate: `cargo fmt --check`; strict workspace Clippy; - PR #130 review round 2 (`b9a7e40`) clamps anchors into the first
1,743 default + 1,919 CRDT library tests (3 ignored each); Stage 1 surviving cell when eviction cuts through a wrapped logical line, prevents
ambient `active_frontend` from minting interactive Lua authority, names
malformed explicit-context fields, restores dispatcher rationale, and
removes owned cell snapshots from terminal mouse routing. The framing now
records the transient v18 semantic-controller boundary and bracketed-paste
injection deferral.
- Second-review final gate: `cargo fmt --check`; strict workspace Clippy;
1,744 default + 1,920 CRDT library tests (3 ignored each); Stage 1
acceptance 9 default + 10 CRDT; Stage 2 acceptance 4 default + 4 CRDT; acceptance 9 default + 10 CRDT; Stage 2 acceptance 4 default + 4 CRDT;
statusline acceptance 7 default + 8 CRDT; M4 114 passed (3 ignored, statusline acceptance 7 default + 8 CRDT; M4 114 passed (3 ignored,
1 filtered); required GPU 109; workspace 2,871 passed across 81 suites 1 filtered); required GPU 109; workspace 2,872 passed across 81 suites
(19 ignored, 1 filtered); `git diff --check` clean. (19 ignored, 1 filtered); `git diff --check` clean.
- **PARKED: kill-ring browser + persistence.** Revision 2 framing is - **PARKED: kill-ring browser + persistence.** Revision 2 framing is
preserved on branch `kill-ring-browser`, but its `0efb5cd` scout is stale preserved on branch `kill-ring-browser`, but its `0efb5cd` scout is stale