neuwirth
/
pmacs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

docs(vterm): record macOS portability fix 

Record the Darwin PTY signal-name mismatch found by PR CI, the normalization
commit, and the final from-start green gate sequence with updated test counts.
This commit is contained in:
Levi Neuwirth 2026-07-21 14:38:52 -04:00
parent 962944b744
commit 4d74d64b6f
2 changed files with 19 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
docs/agent-handoff.md
View File

@ -122,7 +122,8 @@ next machine reads it the way you just did.
as #125 and completed Arc 4 on `main`.
- **Vterm Stage 1 terminal core IMPLEMENTED ON `vterm-core`, FULLY GATED,
AWAITING REVIEW, NOT MERGED** (`docs/vterm-framing.md` rev 3).
- Feature commit: `bbc1f33`; pull request: #126,
- Implementation commits: `bbc1f33` (Stage 1) and `962944b` (Darwin PTY
signal normalization); pull request: #126,
<https://github.com/levineuwirth/pmacs/pull/126> (open, non-draft,
targeting `main`).
- `AnsiParserProfile::{LineOriented, FullScreen}` preserves compile/REPL
@ -146,14 +147,15 @@ next machine reads it the way you just did.
output before exact PID/outcome annotation. One-row annotation visibility,
TERM-ignoring shutdown, spawn rollback, buffer-kill prune, and immutable
empty CRDT bootstrap are pinned.
- Final from-start rerun: Clippy clean; 1,657 default + 1,833 CRDT library
tests (3 ignored each); 8 default + 9 CRDT vterm acceptance; M4 114 passed
(3 ignored, 1 filtered); required GPU 109; workspace 2,764 passed across
79 suites (19 ignored, 1 filtered); diff check clean. The first Clippy
attempt found only missing crate docs in the new acceptance; it was fixed
and the whole sequence restarted. `scripts/bite main src/lib.rs --test
vterm_stage1_acceptance` is green only as the helper's explicitly weaker
compile-time API bite.
- Final from-start rerun after the portability fix: Clippy clean; 1,658
default + 1,834 CRDT library tests (3 ignored each); 8 default + 9 CRDT
vterm acceptance; M4 114 passed (3 ignored, 1 filtered); required GPU 109;
workspace 2,765 passed across 79 suites (19 ignored, 1 filtered); diff
check clean. The first gate pass found only missing crate docs in the new
acceptance; PR CI then exposed Darwin's numeric `strsignal` suffix. Both
fixes were followed by a complete restart from gate 1.
`scripts/bite main src/lib.rs --test vterm_stage1_acceptance` is green only
as the helper's explicitly weaker compile-time API bite.
- Stage 2 reviews require a durable focus/input resize owner, owning
`FrontendId` for the global `C-c` continuation, and local clipboard/BEL
signal drainage. Stage 3 additionally owns `pmacs-gpu/src/attach.rs`,

14
docs/vterm-framing.md
View File

@ -110,18 +110,20 @@ All fourteen Stage 1 criteria are implemented:
### 0.3 Final gates and bite
After one initial Clippy-only failure for the new acceptance crate's missing
module documentation, that source issue was fixed and the complete sequence was
restarted from gate 1:
The initial gate run found and fixed missing module documentation in the new
acceptance crate, then restarted from gate 1. After PR #126 opened, its macOS
Lua 5.4 job exposed Darwin's numeric `strsignal` suffix (`"Terminated: 15"`);
commit `962944b` normalizes both Darwin and glibc descriptions to the same
symbolic signal. The complete sequence restarted from gate 1 again:
- `cargo fmt --check`: clean;
- `cargo clippy --workspace --all-targets -- -D warnings`: clean;
- default library: 1,657 passed, 3 ignored;
- CRDT library: 1,833 passed, 3 ignored;
- default library: 1,658 passed, 3 ignored;
- CRDT library: 1,834 passed, 3 ignored;
- Stage 1 acceptance: 8 default + 9 CRDT passed;
- M4 acceptance: 114 passed, 3 ignored, 1 `basedpyright` filtered;
- required GPU: 109 passed;
- workspace: 2,764 passed across 79 suites, 19 ignored, 1 filtered;
- workspace: 2,765 passed across 79 suites, 19 ignored, 1 filtered;
- `git diff --check`: clean.
`scripts/bite main src/lib.rs --test vterm_stage1_acceptance` returned