Commit Graph

1 Commits

Author SHA1 Message Date
Levi Neuwirth 72102738a7
docs(ci): frame the dark CRDT half of the test corpus
`.github/workflows/ci.yml` never enables the `crdt` feature anywhere, so
every `#[cfg(feature = "crdt")]` test is not compiled in CI — not
skipped, not filtered, not reported. 279 tests have never executed in
CI, and 186 of them are in the library, whose `cargo test --lib
--features crdt` invocation CLAUDE.md lists as a required pre-PR gate.
CI has never once run a required gate.

Named in docs/active-work.md as "NEEDS A LANE" since it was found while
gating #166, with no branch and no owner until now.

Revision 2, approved. What the scout established beyond the ledger:

- The census moved and was re-measured at 4223dd3: 279 dark, not the
  ledger's 273. Plus a fact the old census did not carry — eight test
  binaries contain zero tests under CI flags, so they build, run, and
  report ok with nothing in them.

- "279 dark" overstates the fix. Eleven are #[ignore]d, so a plain crdt
  leg recovers 268. All 279 are now assigned a disposition: 268 by the
  leg, 7 by a new m10-perf-gates job, 3 deliberately manual, 1 an
  ignored known-defect marker. The lane recovers 275 of 279 and the
  other four are excluded for stated reasons rather than left as
  residue.

- The classification docs/active-work.md called "the lane's first task"
  is finished, and it found three dispositions rather than two:
  benches awaiting a job, deliberately-manual operator tests, and
  known-defect markers.

- The ledger's clippy inventory was stale in both directions. It warned
  its own list was "a lower bound, not an inventory" because clippy
  aborts on first failure; --keep-going is what converts it. The
  complete set is eight findings across four files, none behavioral.

- A hole in the proposed fix shape: the gpu-render job runs
  `cargo test -p pmacs-gpu`, a different package from the four root-package
  suites the fix wants to move there. And PMACS_REQUIRE_GPU is absent
  from two of those four, so it cannot serve as blanket proof they ran.

- The full serialized crdt sweep is green: 3,715 passed, 0 failed, 30
  ignored, reconciling exactly to the 3,746 census. That green result
  shaped the acceptance criteria more than a red one would have — a
  green pre-measurement is the condition under which a vacuous CI job
  ships unnoticed, so the criteria gained a count reconciliation and a
  deliberately-broken-test bite.

Revision 1 -> 2 also corrects revision 1's classification of
m10_10_perf, which was wrong in a way that would have made the lane
worse: the suite is a deliberate CI-default regression tripwire with
generous bounds, not a bench, so adding #[ignore] would have shipped a
coverage reduction inside a coverage lane.

Framing only. No workflow change, no source change, no branch plan
executed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-01 09:34:27 -04:00