pmacs

Commit Graph

Author	SHA1	Message	Date
Levi Neuwirth	61a31b3ad4	fix(completion): address TUI-validation findings (LSP query gaps, scoping, prefix keys, window scope) Five findings from the manual validation pass, all in-branch: 1. LSP-only words never queried the server: the auto-open path fired request_completion only when the sync providers already produced rows. An empty sweep now leaves a pending session and the request always fires; isIncomplete responses re-request on further typing. Corollary: attachment_for_request now flushes-if-attached but NEVER attaches -- the first cut wrapped attached_for_active, which spawns servers on demand, i.e. per-keystroke spawn attempts in unattached buffers (wedged the parallel m4 suite; serial ran 3x slower). Attachment stays buffer-open policy. 2. Cross-buffer LSP leak: the built-in provider's no-uri fallback was the legacy global store drain, so scratch/unattached buffers could show another file's cached completions. Strict now: no uri, no rows. 3. Pending prefixes own the keyboard: Action::Pending (C-x ...) dismisses the popup and the popup shadow is guarded on an empty dispatcher prefix, so the sequence's continuation and its C-g abort reach the dispatcher instead of the popup. 4. Window-scoped sessions: CompletionPopupState.window_id (stamped by completion_popup_open; Lua never sees it). Only the owning window's overlay paints -- same-buffer splits each carry a persistent overlay -- and a focus change invalidates the session. 5. Flaky worker test: the /proc thread-count probe and the idempotence check both build EditorStates and could run concurrently, polluting the baseline; merged into one test (non-Linux keeps a portable idempotence variant). Regression tests for 1-4; framing doc gains the as-built notes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-07 16:54:14 -04:00
Levi Neuwirth	21d12b486b	docs: in-buffer completion popup framing (Arc 1a) Framing for wiring the dormant M4.7/M4.11 completion system to real UI in both frontends. Q#C1-C9 decisions: Lua driver, core-owned session (search-store pattern), partial dispatcher shadow with post-dispatch validation, MenuView-style CompletionView rework, protocol v15 CompletionPopup message (phase 2), explicit GPU control-key predicate, validated accept, LSP scoping + flush-before-request, and the single-char trigger heuristic. Incorporates the 2026-07-07 review findings (LSP store scoping, score filtering, didChange flush, motion closure, GPU ESC routing, hook payload policy, context_for nit). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-07 11:24:46 -04:00

Author

SHA1

Message

Date

Levi Neuwirth

61a31b3ad4

fix(completion): address TUI-validation findings (LSP query gaps, scoping, prefix keys, window scope)

Five findings from the manual validation pass, all in-branch:

1. LSP-only words never queried the server: the auto-open path fired
   request_completion only when the sync providers already produced
   rows. An empty sweep now leaves a pending session and the request
   always fires; isIncomplete responses re-request on further typing.
   Corollary: attachment_for_request now flushes-if-attached but NEVER
   attaches -- the first cut wrapped attached_for_active, which spawns
   servers on demand, i.e. per-keystroke spawn attempts in unattached
   buffers (wedged the parallel m4 suite; serial ran 3x slower).
   Attachment stays buffer-open policy.

2. Cross-buffer LSP leak: the built-in provider's no-uri fallback was
   the legacy global store drain, so scratch/unattached buffers could
   show another file's cached completions. Strict now: no uri, no rows.

3. Pending prefixes own the keyboard: Action::Pending (C-x ...)
   dismisses the popup and the popup shadow is guarded on an empty
   dispatcher prefix, so the sequence's continuation and its C-g abort
   reach the dispatcher instead of the popup.

4. Window-scoped sessions: CompletionPopupState.window_id (stamped by
   completion_popup_open; Lua never sees it). Only the owning window's
   overlay paints -- same-buffer splits each carry a persistent
   overlay -- and a focus change invalidates the session.

5. Flaky worker test: the /proc thread-count probe and the idempotence
   check both build EditorStates and could run concurrently, polluting
   the baseline; merged into one test (non-Linux keeps a portable
   idempotence variant).

Regression tests for 1-4; framing doc gains the as-built notes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-07-07 16:54:14 -04:00

Levi Neuwirth

21d12b486b

docs: in-buffer completion popup framing (Arc 1a)

Framing for wiring the dormant M4.7/M4.11 completion system to real UI
in both frontends. Q#C1-C9 decisions: Lua driver, core-owned session
(search-store pattern), partial dispatcher shadow with post-dispatch
validation, MenuView-style CompletionView rework, protocol v15
CompletionPopup message (phase 2), explicit GPU control-key predicate,
validated accept, LSP scoping + flush-before-request, and the
single-char trigger heuristic. Incorporates the 2026-07-07 review
findings (LSP store scoping, score filtering, didChange flush, motion
closure, GPU ESC routing, hook payload policy, context_for nit).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-07-07 11:24:46 -04:00

2 Commits