pmacs

Commit Graph

Author	SHA1	Message	Date
Levi Neuwirth	87e88da024	fix(edit): PR #111 round 1 — scalar-valid UTF-8, per-word capitalize, trim error reporting Finding 1: codepoint recognition is now full UTF-8 scalar validation (shared second-byte constraint table: overlongs, surrogates, and beyond-U+10FFFF all fail), and transpose validates the scalar AT the cursor trailing-bytes-included — a valid lead with non-continuation trailing bytes fails closed, as does a length-consistent overlong or out-of-range span behind the cursor. Zap's single-codepoint check uses the same validator as defense-in-depth (minibuffer contents arrive as Rust-side UTF-8; the buffer-facing checks are the load-bearing ones). Finding 2: capitalize is per-word across the span — Emacs capitalize-region parity, verified against Emacs 30.2 ("hello WORLD" -> "Hello World", "9abc a9bc" -> "9abc A9bc"); the one remaining deviation is named and pinned: `_` is a word constituent in this pack's ASCII class, so "foo_bar" -> "Foo_bar" versus Emacs's "Foo_Bar". Finding 3: an unexpected error caught by the trim-on-save outer pcall is no longer discarded — it reports on the status line AND the errors buffer via pmacs.error (the autosave sweep convention), both pcall'd, still never vetoing the save. All three fixes bite-verified: the five new/updated acceptance cases fail against the pre-fix editops.lua (72 total now). Framing at revision 6. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018vF4gQVozBWi38y1SJiGfQ	2026-07-12 16:34:18 +01:00
Levi Neuwirth	781cd95fe2	feat(edit): editing-conveniences pack (editops) builtin/runtime/editops.lua: goto-line (M-g g / M-g M-g), case ops (M-u/M-l/M-c), transpose chars/words (C-t/M-t), zap-to-char (M-z) + zap-up-to-char, line move/duplicate/join (M-up/M-down/M-^), region sort/reverse/dedupe, delete-trailing-whitespace + opt-in trim_on_save. All edits ride the Q#EC2 guarded single-replace discipline (snapshot, exact effective-triple check, context guard, right-gravity transformed-cursor repair, unconditional selection clear); word/case ops are explicit-byte-range ASCII (locale-proof); transpose-words matches the empirical Emacs 30.2 boundary table. killring.lua: zap commands join KILL_CHAIN; new exports kill_range (validated, chain-aware, typed failure returns), break_chain([fid]), and the Q#EC6 pending-prompt marker (arm/commit; arm-time abandoned-marker break; kill_push force-fresh on an uncommitted marker; detach cleanup) closing the silent-session-replacement hole. Zap guards its origin frontend and re-verifies this_command at accept time; commit_kill_prompt() reports armament so a consumed marker fails closed. editor.rs: editops.lua loader entry before saveplace.lua (the Q#EC9 before-save registration-order contract). tests/editops_acceptance.rs: 68 dispatch-driven cases — RET/C-g completed minibuffer sessions, the boundary-state pin, origin-guard and silent-replacement matrices, the nine-position transpose table, intercept discipline (reject/transform/context-switch/zero-length anchor), trim sweep semantics, and trim-on-save veto interactions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018vF4gQVozBWi38y1SJiGfQ	2026-07-12 15:33:17 +01:00

Author

SHA1

Message

Date

Levi Neuwirth

87e88da024

fix(edit): PR #111 round 1 — scalar-valid UTF-8, per-word capitalize, trim error reporting

Finding 1: codepoint recognition is now full UTF-8 scalar validation
(shared second-byte constraint table: overlongs, surrogates, and
beyond-U+10FFFF all fail), and transpose validates the scalar AT the
cursor trailing-bytes-included — a valid lead with non-continuation
trailing bytes fails closed, as does a length-consistent overlong or
out-of-range span behind the cursor. Zap's single-codepoint check
uses the same validator as defense-in-depth (minibuffer contents
arrive as Rust-side UTF-8; the buffer-facing checks are the
load-bearing ones).

Finding 2: capitalize is per-word across the span — Emacs
capitalize-region parity, verified against Emacs 30.2 ("hello WORLD"
-> "Hello World", "9abc a9bc" -> "9abc A9bc"); the one remaining
deviation is named and pinned: `_` is a word constituent in this
pack's ASCII class, so "foo_bar" -> "Foo_bar" versus Emacs's
"Foo_Bar".

Finding 3: an unexpected error caught by the trim-on-save outer
pcall is no longer discarded — it reports on the status line AND the
*errors* buffer via pmacs.error (the autosave sweep convention),
both pcall'd, still never vetoing the save.

All three fixes bite-verified: the five new/updated acceptance cases
fail against the pre-fix editops.lua (72 total now). Framing at
revision 6.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018vF4gQVozBWi38y1SJiGfQ

2026-07-12 16:34:18 +01:00

Levi Neuwirth

781cd95fe2

feat(edit): editing-conveniences pack (editops)

builtin/runtime/editops.lua: goto-line (M-g g / M-g M-g), case ops
(M-u/M-l/M-c), transpose chars/words (C-t/M-t), zap-to-char (M-z) +
zap-up-to-char, line move/duplicate/join (M-up/M-down/M-^), region
sort/reverse/dedupe, delete-trailing-whitespace + opt-in
trim_on_save. All edits ride the Q#EC2 guarded single-replace
discipline (snapshot, exact effective-triple check, context guard,
right-gravity transformed-cursor repair, unconditional selection
clear); word/case ops are explicit-byte-range ASCII (locale-proof);
transpose-words matches the empirical Emacs 30.2 boundary table.

killring.lua: zap commands join KILL_CHAIN; new exports kill_range
(validated, chain-aware, typed failure returns), break_chain([fid]),
and the Q#EC6 pending-prompt marker (arm/commit; arm-time
abandoned-marker break; kill_push force-fresh on an uncommitted
marker; detach cleanup) closing the silent-session-replacement hole.
Zap guards its origin frontend and re-verifies this_command at
accept time; commit_kill_prompt() reports armament so a consumed
marker fails closed.

editor.rs: editops.lua loader entry before saveplace.lua (the Q#EC9
before-save registration-order contract).

tests/editops_acceptance.rs: 68 dispatch-driven cases — RET/C-g
completed minibuffer sessions, the boundary-state pin, origin-guard
and silent-replacement matrices, the nine-position transpose table,
intercept discipline (reject/transform/context-switch/zero-length
anchor), trim sweep semantics, and trim-on-save veto interactions.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018vF4gQVozBWi38y1SJiGfQ

2026-07-12 15:33:17 +01:00

2 Commits