Levi Neuwirth
c49daa0bab
Three PR #96 review findings (documentation accuracy): - Q#P7 coordinates section claimed panels inherit a byte==UTF-16 wire assumption with position-encoding hardening deferred. False as-built: the transport layer negotiates general.positionEncoding and converts every Position at the request/response boundary (PositionEncoding + char_to_byte/byte_to_char, src/lsp.rs), so location rows reach Lua as byte offsets. Reworded to record what landed; the true residual is the codepoint-vs-byte cursor walk in move_active_cursor_to (shared with go_to_definition, not introduced by panels). - Intro described pre-arc behavior in present tense (references throw rows away, code actions apply acts[1] blind, ...). Marked as the pre-arc baseline with a status banner + inline as-built pointers. - Drifted hard-coded line refs (editor_core.rs:2052-2071, lsp.lua:658-662, lsp.lua:1187-1213) replaced with symbol names. Also fixed the move_active_cursor_to comment in lsp.lua itself — it was the same 'v0.2 hardening' false trail the doc's stale ref pointed at, now naming the real residual (codepoint-walk, not wire encoding). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| async.lua | ||
| completion.lua | ||
| fs.lua | ||
| listview.lua | ||
| lsp.lua | ||
| mcp.lua | ||
| syntax.lua | ||